Skip to content

fix(optimizer): remove backdrop-filter from vite-error-overlay for perf#7676

Merged
gioboa merged 2 commits intoQwikDev:mainfrom
intellix:issue-7675-vite-error-blur
Jun 18, 2025
Merged

fix(optimizer): remove backdrop-filter from vite-error-overlay for perf#7676
gioboa merged 2 commits intoQwikDev:mainfrom
intellix:issue-7675-vite-error-blur

Conversation

@intellix
Copy link
Contributor

@intellix intellix commented Jun 18, 2025

What is it?

  • Bug

Description

Removes the backdrop-filter/blur when an error appears. In the event that you have multiple error overlays, it causes my Super Computer (M4 Max) to absolutely crawl.

Closes #7675

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@intellix intellix requested a review from a team as a code owner June 18, 2025 13:03
@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: 56468a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@intellix intellix force-pushed the issue-7675-vite-error-blur branch from 390cdcc to 7b942f6 Compare June 18, 2025 13:05
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7676
npm i https://pkg.pr.new/@builder.io/qwik-city@7676
npm i https://pkg.pr.new/eslint-plugin-qwik@7676
npm i https://pkg.pr.new/create-qwik@7676

commit: 7b942f6

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 7b942f6

gioboa
gioboa previously approved these changes Jun 18, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback @intellix
Can you share the before and after screenshots please?

@wmertens
Copy link
Member

Note that the real bug here is that there should only be one error overlay

@intellix
Copy link
Contributor Author

intellix commented Jun 18, 2025

It was really hard for me to get a before/after because my browser tab is pretty much crashing with the blur on the stacked errors, but I couldn't really see any difference between the before/after

Screenshot 2025-06-18 at 15 09 11 Screenshot 2025-06-18 at 15 13 07

@wmertens
Copy link
Member

could you quickly change the changeset to patch @intellix ?

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @intellix

@gioboa gioboa merged commit da5a118 into QwikDev:main Jun 18, 2025
14 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐞] Vite error overlay causes CPU/GPU to go insane

3 participants