Skip to content

fix: bundlegraph as regular asset#7650

Merged
wmertens merged 4 commits intomainfrom
bg-asset
Jun 2, 2025
Merged

fix: bundlegraph as regular asset#7650
wmertens merged 4 commits intomainfrom
bg-asset

Conversation

@wmertens
Copy link
Member

@wmertens wmertens commented Jun 1, 2025

  • make bundlegraph a regular asset and don't assume anything about the path
  • add assets list to q-manifest

This fixes issues with i18n and is cleaner

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2025

🦋 Changeset detected

Latest commit: b583647

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wmertens added 2 commits June 1, 2025 14:36
- don't assume path of bundlegraph during render
- move bundlegraph to standard assets location
- refactor preloader script output
@wmertens wmertens marked this pull request as ready for review June 2, 2025 04:05
@wmertens wmertens requested review from a team as code owners June 2, 2025 04:05
this allows knowing all the needed files for offline apps
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7650
npm i https://pkg.pr.new/@builder.io/qwik-city@7650
npm i https://pkg.pr.new/eslint-plugin-qwik@7650
npm i https://pkg.pr.new/create-qwik@7650

commit: b583647

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b583647

- the bundlegraph asset is not relative to build/
- the resolved manifest in the server only has a selection of manifest keys
@wmertens wmertens self-assigned this Jun 2, 2025
@wmertens wmertens enabled auto-merge June 2, 2025 06:09
@shairez shairez moved this from Backlog to Waiting For Review in Qwik Development Jun 2, 2025
Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@wmertens wmertens merged commit cf3a8aa into main Jun 2, 2025
22 checks passed
@wmertens wmertens deleted the bg-asset branch June 2, 2025 08:59
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Jun 2, 2025
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants