Skip to content

fix(rollup): call fileName hook with assetsDir and debug:true#7638

Merged
wmertens merged 2 commits intoQwikDev:mainfrom
maiieul:fix-rollup-filename-with-assetsDir
Jun 2, 2025
Merged

fix(rollup): call fileName hook with assetsDir and debug:true#7638
wmertens merged 2 commits intoQwikDev:mainfrom
maiieul:fix-rollup-filename-with-assetsDir

Conversation

@maiieul
Copy link
Member

@maiieul maiieul commented May 24, 2025

What is it?

  • Bug

Description

AssetsDir and debug:true would break https://discord.com/channels/842438759945601056/1373329617456332982/1375777547748507740.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner May 24, 2025 13:20
@changeset-bot
Copy link

changeset-bot bot commented May 24, 2025

⚠️ No Changeset found

Latest commit: da4fe0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7638
npm i https://pkg.pr.new/@builder.io/qwik-city@7638
npm i https://pkg.pr.new/eslint-plugin-qwik@7638
npm i https://pkg.pr.new/create-qwik@7638

commit: 5480188

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 5480188

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development May 25, 2025
@maiieul maiieul self-assigned this May 29, 2025
@maiieul maiieul added bug Something isn't working DX Developer Experience related issue labels May 29, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧇

@wmertens wmertens merged commit 80f318d into QwikDev:main Jun 2, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Jun 2, 2025
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working DX Developer Experience related issue

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants