Skip to content

feat(cli): add ability to keep using tailwind v3#7403

Merged
maiieul merged 1 commit intoQwikDev:mainfrom
maiieul:tailwind-v3-support
Mar 11, 2025
Merged

feat(cli): add ability to keep using tailwind v3#7403
maiieul merged 1 commit intoQwikDev:mainfrom
maiieul:tailwind-v3-support

Conversation

@maiieul
Copy link
Member

@maiieul maiieul commented Mar 8, 2025 •
edited
Loading

What is it?

  • Feature / enhancement

Description

Some projects might not be able to use tailwind v4 yet. qwik-ui/styled hasn't been updated for tailwind v4 yet. I think even after updating to tailwind v4, we should keep a qwik-ui subdomain live for tailwind v3 for some time.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested review from a team as code owners March 8, 2025 15:22
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 407e707

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 8, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7403

npm i https://pkg.pr.new/@builder.io/qwik-city@7403

npm i https://pkg.pr.new/eslint-plugin-qwik@7403

npm i https://pkg.pr.new/create-qwik@7403

commit: ac5c36e

@maiieul maiieul force-pushed the tailwind-v3-support branch from 37aedc9 to 872b279 Compare March 8, 2025 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview ac5c36e

@maiieul maiieul force-pushed the tailwind-v3-support branch from 872b279 to ac5c36e Compare March 8, 2025 16:36
maiieul
maiieul commented Mar 8, 2025
View reviewed changes
@maiieul maiieul force-pushed the tailwind-v3-support branch from ac5c36e to 407e707 Compare March 8, 2025 17:00
wmertens
wmertens approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gioboa
gioboa approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great idea 👏

@maiieul maiieul merged commit d297d3e into QwikDev:main Mar 11, 2025
14 checks passed
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmertens wmertens wmertens approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maiieul @wmertens @gioboa