Skip to content

deprecated useTask$ eagerness#7345

Merged
wmertens merged 7 commits intoQwikDev:mainfrom
sreeisalso:deprecate-eagerness
Mar 1, 2025
Merged

deprecated useTask$ eagerness#7345
wmertens merged 7 commits intoQwikDev:mainfrom
sreeisalso:deprecate-eagerness

Conversation

@sreeisalso
Copy link
Contributor

@sreeisalso sreeisalso commented Feb 16, 2025 •
edited
Loading

What is it?

  • Feature / enhancement

Description

discord discussion https://discord.com/channels/842438759945601056/1146057166273400906/1294339900350660659
github task Qwik Development (view)

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a75f037

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 16, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7345

npm i https://pkg.pr.new/@builder.io/qwik-city@7345

npm i https://pkg.pr.new/eslint-plugin-qwik@7345

npm i https://pkg.pr.new/create-qwik@7345

commit: a75f037

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview a75f037

@sreeisalso sreeisalso marked this pull request as ready for review February 16, 2025 10:53
@sreeisalso sreeisalso requested review from a team as code owners February 16, 2025 10:53
Varixo
Varixo reviewed Feb 16, 2025
View reviewed changes
@sreeisalso
Copy link
Contributor Author

sreeisalso commented Feb 17, 2025

@Varixo updated

Varixo
Varixo previously approved these changes Feb 18, 2025
View reviewed changes
@sreeisalso sreeisalso requested a review from Varixo February 18, 2025 15:21
maiieul
maiieul reviewed Feb 21, 2025
View reviewed changes
maiieul
maiieul requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@maiieul maiieul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changeset? 🙏

@sreeisalso
Copy link
Contributor Author

sreeisalso commented Feb 23, 2025

@maiieul added changeset, and updated the deprecation warning as well

@sreeisalso sreeisalso requested a review from maiieul February 23, 2025 07:02
wmertens
wmertens approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@wmertens wmertens merged commit 07a45f4 into QwikDev:main Mar 1, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Mar 1, 2025
@sreeisalso sreeisalso deleted the deprecate-eagerness branch March 10, 2025 07:18
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmertens wmertens wmertens approved these changes

@maiieul maiieul maiieul approved these changes

@Varixo Varixo Awaiting requested review from Varixo

Assignees

@sreeisalso sreeisalso

Labels

None yet

Projects

Qwik Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sreeisalso @wmertens @maiieul @Varixo