Skip to content

add monorepo support to the CLI #7059

Merged
shairez merged 1 commit intomainfrom
pr-cli-monorepo
Nov 17, 2024
Merged

add monorepo support to the CLI #7059
shairez merged 1 commit intomainfrom
pr-cli-monorepo

Conversation

@shairez
Copy link
Contributor

@shairez shairez commented Nov 11, 2024 •
edited
Loading

What is it?

  • Feature / enhancement

Description

added projectDir param to the cli, so the add command could generate files into a sub folder of a monorepo.

plus, added alwaysInRoot prop to the integrations config on the CLI, to mark what should always stay in the root folder even when using the --projectDir= param.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 11, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7059

npm i https://pkg.pr.new/@builder.io/qwik-city@7059

npm i https://pkg.pr.new/eslint-plugin-qwik@7059

npm i https://pkg.pr.new/create-qwik@7059

commit: 1cf13bc

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1cf13bc

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1cf13bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shairez shairez force-pushed the pr-cli-monorepo branch 4 times, most recently from f4de901 to 6f2e365 Compare November 12, 2024 13:04
@shairez shairez self-assigned this Nov 12, 2024
@shairez shairez force-pushed the pr-cli-monorepo branch 3 times, most recently from ae51d40 to abb2570 Compare November 13, 2024 09:17
@shairez shairez marked this pull request as ready for review November 13, 2024 09:18
@shairez shairez requested review from a team as code owners November 13, 2024 09:18
@shairez shairez enabled auto-merge November 13, 2024 09:35
wmertens
wmertens previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good but not entirely sure about some of the root files

LGTM

wmertens
wmertens approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@shairez shairez merged commit 8d1a7c4 into main Nov 17, 2024
@shairez shairez deleted the pr-cli-monorepo branch November 17, 2024 19:59
This was referenced Nov 17, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmertens wmertens wmertens approved these changes

Assignees

@shairez shairez

Labels

None yet

Projects

Qwik Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shairez @wmertens