update FFI definitions in objimpl.h to not expose private symbols#5591
Merged
davidhewitt merged 3 commits intoPyO3:mainfrom Nov 30, 2025
Merged
update FFI definitions in objimpl.h to not expose private symbols#5591davidhewitt merged 3 commits intoPyO3:mainfrom
objimpl.h to not expose private symbols#5591davidhewitt merged 3 commits intoPyO3:mainfrom
Conversation
Icxolu
approved these changes
Nov 29, 2025
Comment on lines
+41
to
+44
| #[inline] | ||
| pub unsafe fn PyObject_New<T>(typeobj: *mut PyTypeObject) -> *mut T { | ||
| _PyObject_New(typeobj).cast() | ||
| } |
Member
There was a problem hiding this comment.
This feels a bit weird to do, but I guess that's best approximation of what CPython does.
Member
Author
There was a problem hiding this comment.
Agreed, it seemed like the cleanest way to expose the public API.
Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes private symbols, they are wrapped by macros which do a pointer cast so I've done the same here.