Fix a soundness bug with PyClassInitializer#4454
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Aug 21, 2024
Merged
Conversation
alex
reviewed
Aug 19, 2024
Member
alex
left a comment
There was a problem hiding this comment.
This LGTM. We still have unsoundness because you can do PyClassInitializer::new(SubClass{}, PyClassInitializer::from(Py::new(py, Baseclass{}))) though :-(
Do you see a good way to deal with that? Maybe PyClassInitializer::new just shouldn't be public, is there a reason to use it?
davidhewitt
reviewed
Aug 19, 2024
Member
davidhewitt
left a comment
There was a problem hiding this comment.
The ::new in particular is a bit strange given it's asking for inheritance, I would be ok with removing it (maybe by making it panic immediately for the Existing case and deprecating the symbol, to be at least a little graceful to users).
1749f4c to
fcecffb
Compare
Contributor
Author
|
@alex Fixed the issue with |
16abef4 to
2159f0f
Compare
From now you cannot initialize a `PyClassInitializer<SubClass>` with `PyClassInitializer::from(Py<BaseClass>).add_subclass(SubClass)`. This was out of bounds write. Now it panics. See details at PyO3#4452.
2159f0f to
01edfde
Compare
Contributor
Author
|
I cannot reproduce valgrind's failure locally. @davidhewitt can you help with that? |
Member
|
See #4463, I pinned main back, this should merge ok now. |
davidhewitt
pushed a commit
that referenced
this pull request
Sep 3, 2024
From now you cannot initialize a `PyClassInitializer<SubClass>` with `PyClassInitializer::from(Py<BaseClass>).add_subclass(SubClass)`. This was out of bounds write. Now it panics. See details at #4452.
davidhewitt
pushed a commit
that referenced
this pull request
Sep 3, 2024
From now you cannot initialize a `PyClassInitializer<SubClass>` with `PyClassInitializer::from(Py<BaseClass>).add_subclass(SubClass)`. This was out of bounds write. Now it panics. See details at #4452.
davidhewitt
pushed a commit
that referenced
this pull request
Sep 15, 2024
From now you cannot initialize a `PyClassInitializer<SubClass>` with `PyClassInitializer::from(Py<BaseClass>).add_subclass(SubClass)`. This was out of bounds write. Now it panics. See details at #4452.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From now you cannot initialize a
PyClassInitializer<SubClass>withPyClassInitializer::from(Py<BaseClass>).add_subclass(SubClass).This was out of bounds write. Now it panics. See details at #4452.
This is a short-term fix for #4452.
Long-term, we probably want to forbid that at compile time, but that will be a breaking change.