Merged
Conversation
71202f8 to
b8bb1e4
Compare
Icxolu
reviewed
Jul 28, 2024
Member
Icxolu
left a comment
There was a problem hiding this comment.
Thanks for helping out with these, much appreciated! This all looks good, but for IntoPyDict, which is breaking for implementers, we should probably add a changelog entry and maybe a small example in the migration guide.
f890653 to
eb8db05
Compare
eb8db05 to
8ad8b2e
Compare
Icxolu
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readded the non-bound contructors to
PyDict&IntoPyDict, hopefully this time more thorough.