add #[track_caller] to all Py/Bound/Borrowed methods which panic#4098
Merged
adamreichold merged 1 commit intoPyO3:mainfrom Apr 19, 2024
Merged
add #[track_caller] to all Py/Bound/Borrowed methods which panic#4098adamreichold merged 1 commit intoPyO3:mainfrom
#[track_caller] to all Py/Bound/Borrowed methods which panic#4098adamreichold merged 1 commit intoPyO3:mainfrom
Conversation
5c9194e to
8bdbb00
Compare
CodSpeed Performance ReportMerging #4098 will not alter performanceComparing 🎉 Hooray!
|
adamreichold
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging pydantic/pydantic#9250 this morning, I realised it would be much more helpful if the panic message originated from the actual source location that attempted to construct the failed pointer, rather than deep in the guts of PyO3.
With this enabled, that reproduction actually panics with:
which is in
PyAnyMethods::dir- it turns out that__dir__can indeed be fallible, so I'll open a separate issue for that now...