fix compile error for multiple async method arguments#4035
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Apr 2, 2024
Merged
fix compile error for multiple async method arguments#4035davidhewitt merged 1 commit intoPyO3:mainfrom
davidhewitt merged 1 commit intoPyO3:mainfrom
Conversation
davidhewitt
commented
Apr 2, 2024
| } | ||
|
|
||
| #[test] | ||
| fn test_async_method_receiver_with_other_args() { |
Member
Author
There was a problem hiding this comment.
Moved the test down as the ordering in the file made more sense to me the other way around.
Icxolu
approved these changes
Apr 2, 2024
Contributor
|
Oops, sorry for the trouble. Thanks for the fix, that is the first time to touch Procedural macros for me. 🙇 |
Member
Author
|
Not a problem at all. I've made the same mistake before with separators and really should have noticed it in review! |
davidhewitt
added a commit
that referenced
this pull request
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4034
I missed in review that the
;was only being applied once at the end of the#evaluate_argexpansion.While at it I tidied this implementation up a bit further. I probably should have reviewed #4015 better; it's been a long week 🤦