refactor to remove add_to_module functions from generated code#4009
Merged
davidhewitt merged 3 commits intoPyO3:mainfrom Mar 29, 2024
Merged
refactor to remove add_to_module functions from generated code#4009davidhewitt merged 3 commits intoPyO3:mainfrom
davidhewitt merged 3 commits intoPyO3:mainfrom
Conversation
CodSpeed Performance ReportMerging #4009 will not alter performanceComparing 🎉 Hooray!
|
Member
|
This significantly improved the coverage situation. We still have a few things missing coverage:
|
Member
|
For clarity, I think it makes sense to merge this and then we can do follow up PRs resolving the other coverage issues. |
Member
Author
|
Great, will merge now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3989
@alex / @reaperhulk, want to try this branch with the cryptography CI and see if it fixes (or reduces) the problem?
This reshapes the generated macro output so that it only emits constants (no functions) and then we leave the implementations inside PyO3's
impl_module, as I suggested on that issue. This is probably better for binary size / compile times even if it doesn't help the coverage problem.