add experimental-async feature#3931
Merged
davidhewitt merged 3 commits intoPyO3:mainfrom Mar 6, 2024
Merged
Conversation
a59c45f to
37b6412
Compare
CodSpeed Performance ReportMerging #3931 will improve performances by 10.74%Comparing Summary
Benchmarks breakdown
|
5737509 to
fcdcbc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3848
As proposed in that issue, this PR adds an
experimental-asyncfeature. I think it's pretty close to done, but we didn't ever merge the last parts. I'd like to mark it as experimental to give us a bit of extra mandate to make changes to things like theCoroutinetype as well as denote this as somewhere we'd like some extra user input.