Add support for SmallVec in conversion traits (#3440)#3507
Add support for SmallVec in conversion traits (#3440)#3507davidhewitt merged 3 commits intoPyO3:mainfrom
SmallVec in conversion traits (#3440)#3507Conversation
9834626 to
e5eda2b
Compare
e5eda2b to
dfeae47
Compare
|
Thank you! FYI other maintainers this was built with my collaboration in the EuroRust impl room, so it's best if I don't review (but can be responsible for follow up tidying). |
| num-complex = { version = ">= 0.2, < 0.5", optional = true } | ||
| rust_decimal = { version = "1.0.0", default-features = false, optional = true } | ||
| serde = { version = "1.0", optional = true } | ||
| smallvec = { version = "1.11.1", optional = true } |
There was a problem hiding this comment.
What do you mean? "smallvec = 1.0"
There was a problem hiding this comment.
Yes, in general we try to accept as broad ranges of optional dependency versions as possible so that we don't have to force users to use specific versions.
|
Added in 31acf0d |
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks again @orhun and good to meet you at EuroRust - I think this looks good now, so I'll merge it 👍
|
CI failure looks caused by latest psutil release; I can try to fix separately later. |
|
Thanks @davidhewitt, it was nice to meet you as well, wish to see you again in events/open source world! |
closes #3440