Remove non-MIT contributions#3387
Merged
davidhewitt merged 5 commits intoPyO3:mainfrom Aug 15, 2023
Merged
Conversation
Contributor
|
I just double-checked we weren't missing anyone. Every boxes are now ticked except for the people mentioned here! |
Member
|
Yeah, I'm not sure I've ever done anything with a debug interpreter + pyo3, so no impact for us. |
adamreichold
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #2339 (comment)
This PR reverts commits by @cecini, @potocpav, and @thanatos, who have been the non-respondents to our intent to relicense.
Mostly these lines have been reworked or replaced already, so the majority of these reverts are empty and purely present for ceremonial purpose.
The one possible change which was meaningful was correct handling of
Py_TRACE_REFSflag which was part ofPy_DEBUGup to and including 3.7. Therefore to move forward I propose to drop support for debug builds on Python 3.7. @alex I assume that dropping support of 3.7 debug interpreters will not impact cryptography, given debug wheels aren't shipped to PyPI.