add PyErr::display#3334
Merged
adamreichold merged 1 commit intoPyO3:mainfrom Jul 25, 2023
Merged
Conversation
Member
There seems to be something missing from the above? |
Member
Author
Yes, I meant to say "added to the documentation", got distracted halfway writing 🤦 |
cde9141 to
b2d34ef
Compare
mejrs
reviewed
Jul 22, 2023
b2d34ef to
a156148
Compare
adamreichold
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking at 3.12 FFI changes I saw the new
PyErr_DisplayExceptionand this inspired me to addPyErr::Displayfor all versions.While looking at this I noticed that
PyErr_PrintExwill callsys.excepthook, so I added this to the documentation.I think we generally want to be using
.display()instead of.print()in tests because there's no meaning to callingsys.excepthookthere, so I updated the callsites.