Conversation
76c5713 to
0f6d141
Compare
145a0a2 to
19d0150
Compare
19d0150 to
1bbd556
Compare
|
Looks like there's a bunch of clippy warnings come alive that are unhappy about passing slices where an array will do. |
|
Yes, I will correct that later on. It's expected, the first commit of this PR removed some clippy exclusions incompatible with 1.48. |
|
It looks like this is going to pass, so I'm going to push it through as we're all in favour of having this. @adamreichold I'm sure there's plenty of tidy-ups we can land now that we've done the MSRV bump. I guess at the very least I will try sometime to go through the Rust release notes and audit for changes we can migrate to. Feel free to push any cleanup PRs for stuff you've noticed or have on a list! |
|
bors r+ |
adamreichold
left a comment
There was a problem hiding this comment.
I see we already silently turned Clippy into check specificially for 1.48 but of course this broke when switching to 1.56. I think the solution with a separate CI job is strictly better so that people (include ourselves) understand what is going without remembering or finding the single if statement in our Nox manifest.
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
The MSRV changes from #3204, plus a commit which should hopefully make CI pass.
With luck this is mergeable and resolves CI pain while we decide what to do about the Python version.