Pre-allocate slice in generic Map function#469
Merged
mna merged 1 commit intoPuerkitoBio:masterfrom Feb 29, 2024
jwilsson:pre-allocate-slice-in-map
Merged
Pre-allocate slice in generic Map function#469mna merged 1 commit intoPuerkitoBio:masterfrom jwilsson:pre-allocate-slice-in-map
mna merged 1 commit intoPuerkitoBio:masterfrom
jwilsson:pre-allocate-slice-in-map
Conversation
Member
|
Hey Jonathan, Thanks for this! That behaviour actually predates the new Martin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Thanks for this great library, really helped me out with some scraping!
I noticed that the generic
Mapfunction just added the other week alwaysappends, growing the slice as needed instead of pre-allocating it upfront.Benchmark results from my M1:
If you think it's not worth it, no hard feelings. Just thought it would be a fun, easy, optimization to make.