test: ProjectCodeTest::testExpectedInputOrder - move checks for testFix... methods#9291
Merged
test: ProjectCodeTest::testExpectedInputOrder - move checks for testFix... methods#9291
ProjectCodeTest::testExpectedInputOrder - move checks for testFix... methods#9291Conversation
…stFix...` methods
d75cb98 to
4688ef2
Compare
ProjectCodeTest::testExpectedInputOrder\ - more checks for \te…stFix...\ methodsProjectCodeTest::testExpectedInputOrder - more checks for testFix... methods
kubawerlos
reviewed
Dec 13, 2025
| ); | ||
| } | ||
|
|
||
| if (isset($parameterNames[1], $parameterNamesToPosition['input'])) { |
Member
There was a problem hiding this comment.
I wonder which approach we should have (it applies to all param positions/names):
- If there is 2nd paramenter, it should be named
input(from the other PR). - If there is a parameter named
input, it should be at 2nd position (this PR).
I prefer 1 as it would also guarantee no typos in param names, as well as will find this: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.92.0/tests/Fixer/FunctionNotation/NullableTypeDeclarationForDefaultNullValueFixerTest.php#L346
Member
Author
There was a problem hiding this comment.
especially on brought example, totally ok to have expected + configuration, without input.
Member
Author
There was a problem hiding this comment.
actually, only one case like that, let me go with your suggestion # 1
# Conflicts: # tests/Fixer/FunctionNotation/NullableTypeDeclarationForDefaultNullValueFixerTest.php # tests/Test/AbstractFixerTestCase.php
# Conflicts: # tests/Test/AbstractFixerTestCase.php
ProjectCodeTest::testExpectedInputOrder - more checks for testFix... methodsProjectCodeTest::testExpectedInputOrder - move checks for testFix... methods
stakovicz
pushed a commit
to stakovicz/PHP-CS-Fixer
that referenced
this pull request
Jan 4, 2026
…stFix...` methods (PHP-CS-Fixer#9291)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially replaces #9289 (comment)