Skip to content

chore: Runner - better input types handling#9286

Merged
keradus merged 2 commits intomasterfrom
fix_Type
Dec 10, 2025
Merged

chore: Runner - better input types handling#9286
keradus merged 2 commits intomasterfrom
fix_Type

Conversation

@keradus
Copy link
Copy Markdown
Member

@keradus keradus commented Dec 10, 2025

@keradus
Copy link
Copy Markdown
Member Author

keradus commented Dec 10, 2025

fyi @mlocati

@keradus keradus marked this pull request as ready for review December 10, 2025 15:04
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 93.186% (+0.001%) from 93.185%
when pulling 6efcd6f on fix_Type
into 6b5911a on master.

@mlocati
Copy link
Copy Markdown
Contributor

mlocati commented Dec 10, 2025

LGTM

Comment thread src/Runner/Runner.php
$missingFixerNames = array_diff(
array_map(
// key may be `int` if custom implementation of Policy doesn't fulfill the contract properly
static fn (/* int|string */ $name): string => (string) $name, // @phpstan-ignore cast.useless
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a simple 'strval' would have worked, but the closure approach works too

@keradus keradus merged commit e4461ae into master Dec 10, 2025
32 of 33 checks passed
@keradus keradus deleted the fix_Type branch December 10, 2025 16:56
stakovicz pushed a commit to stakovicz/PHP-CS-Fixer that referenced this pull request Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants