UX: better gitlab reporting - more user-friendly description field#9141
Merged
keradus merged 6 commits intoPHP-CS-Fixer:masterfrom Oct 18, 2025
Merged
Conversation
keradus
reviewed
Oct 15, 2025
| private function registerFixers() | ||
| { | ||
| $fixerFactory = new FixerFactory(); | ||
| $fixerFactory->registerBuiltInFixers(); |
Contributor
Author
There was a problem hiding this comment.
Good point mentioned. I'll add the custom ones.
Member
There was a problem hiding this comment.
I'm OK to have it added as separated PR
keradus
reviewed
Oct 15, 2025
| $report[] = [ | ||
| 'check_name' => 'PHP-CS-Fixer.'.$fixerName, | ||
| 'description' => 'PHP-CS-Fixer.'.$fixerName.' by '.$about, | ||
| 'description' => $description, |
Contributor
Author
There was a problem hiding this comment.
Ok I will add about part.
How will the description field look like finally? Like this: ??
'description' => 'PHP-CS-Fixer.' . $description . ' by ' . $about,
Member
There was a problem hiding this comment.
try out what it will produce. description is a sentence (or even multiple ones), this proposal will not look good.
maybe sprintf("%.% by %: %", 'PHP-CS-Fixer', $fixerName, $about, $description) ?
or even "%.% by %:\n%" if gitlab allows multi-line ?
2 tasks
# Conflicts: # src/Console/Report/FixReport/GitlabReporter.php
keradus
approved these changes
Oct 18, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitLab reporter now outputs the description for each fixer. This will make it better understand the issue in the code-quality panel.
Also remove the about part from description, didn't provided anything useful.