deps: pin checkbashisms and shellcheck to stable URL with pinned version#9032
Merged
keradus merged 3 commits intoPHP-CS-Fixer:masterfrom Sep 8, 2025
Merged
deps: pin checkbashisms and shellcheck to stable URL with pinned version#9032keradus merged 3 commits intoPHP-CS-Fixer:masterfrom
keradus merged 3 commits intoPHP-CS-Fixer:masterfrom
Conversation
…ion, to avoid random installation failures
Wirone
reviewed
Sep 8, 2025
| --output-document=bin/checkbashisms | ||
| chmod u+x bin/checkbashisms | ||
| fi | ||
| bin/checkbashisms --version |
Member
There was a problem hiding this comment.
Is it actually needed if we install Check Bashism using VERSION_CB? I see we print this also for the other tool, which previously had stable (then it made sense to print the exact version), so maybe both --version lines are superfluous now?
Member
Author
There was a problem hiding this comment.
this command was actually introduced with a purpose to show that script is present, properly installed and runnable.
no strong opinion
Member
Author
|
merging for now. feel free to improve with follow-up PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid random installation failures