Skip to content

chore: PhpUnitTestAnnotationFixer - use foreach instead of for#8911

Merged
keradus merged 5 commits intoPHP-CS-Fixer:masterfrom
gharlan:foreach
Aug 6, 2025
Merged

chore: PhpUnitTestAnnotationFixer - use foreach instead of for#8911
keradus merged 5 commits intoPHP-CS-Fixer:masterfrom
gharlan:foreach

Conversation

@gharlan
Copy link
Copy Markdown
Member

@gharlan gharlan commented Aug 5, 2025

Intention: simplify code, resolve some phpstan errors

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 5, 2025

Coverage Status

coverage: 94.718% (-0.01%) from 94.728%
when pulling dfcd321 on gharlan:foreach
into 4e4ca8a on PHP-CS-Fixer:master.

@gharlan
Copy link
Copy Markdown
Member Author

gharlan commented Aug 5, 2025

The new phpstan error is discussed in phpstan/phpstan#13312

@keradus keradus enabled auto-merge (squash) August 5, 2025 20:35
@keradus
Copy link
Copy Markdown
Member

keradus commented Aug 5, 2025

let's add that one to baseline till solved

@keradus keradus merged commit 57768e7 into PHP-CS-Fixer:master Aug 6, 2025
31 checks passed
@gharlan gharlan deleted the foreach branch August 7, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants