Skip to content

fix: MethodArgumentSpaceFixer - handle when nested in HTML#8503

Merged
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
6b7562617765726c6f73:fix_MethodArgumentSpaceFixer
Mar 13, 2025
Merged

fix: MethodArgumentSpaceFixer - handle when nested in HTML#8503
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
6b7562617765726c6f73:fix_MethodArgumentSpaceFixer

Conversation

@kubawerlos
Copy link
Copy Markdown
Member

Fixes #8502

Please, notice that the failures before the fix are:

Code built on expected code must not change.

and

Expected no changes made to test "Integration of fixers: method_argument_space,statement_indentation. "--EXPECT-- part run"" in "misc/method_argument_space,statement_indentation.test".

@kubawerlos kubawerlos force-pushed the fix_MethodArgumentSpaceFixer branch from e808ab0 to 1ec40b1 Compare March 13, 2025 16:13
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 94.845% (+0.3%) from 94.502%
when pulling 1ec40b1 on 6b7562617765726c6f73:fix_MethodArgumentSpaceFixer
into 2b85ed7 on PHP-CS-Fixer:master.

Copy link
Copy Markdown
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall OKish to merge as change is minimal, but I do not want to support any mixed PHP/HTML code.

@keradus keradus merged commit e28458b into PHP-CS-Fixer:master Mar 13, 2025
@keradus keradus deleted the fix_MethodArgumentSpaceFixer branch March 13, 2025 18:11
@kubawerlos
Copy link
Copy Markdown
Member Author

I do not want to support any mixed PHP/HTML code.

Me neither, but the tool does, at least in v3.

@keradus
Copy link
Copy Markdown
Member

keradus commented Mar 13, 2025

but we may still not prioritise any work on it

@kubawerlos
Copy link
Copy Markdown
Member Author

Bugfixes, PHP 8.4 support and PER-CS all have higher priority on my list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

method_argument_space and statement_indentation keep adding more spaces to html file with inline php

3 participants