Skip to content

test: fix CheckCommandTest::testDryRunModeIsUnavailable to correctly check that option --dry-run is unavailable#8438

Merged
keradus merged 3 commits intoPHP-CS-Fixer:masterfrom
6b7562617765726c6f73:fix_CheckCommandTest
Feb 22, 2025
Merged

test: fix CheckCommandTest::testDryRunModeIsUnavailable to correctly check that option --dry-run is unavailable#8438
keradus merged 3 commits intoPHP-CS-Fixer:masterfrom
6b7562617765726c6f73:fix_CheckCommandTest

Conversation

@kubawerlos
Copy link
Copy Markdown
Member

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 15, 2025

Coverage Status

coverage: 94.948% (+0.4%) from 94.583%
when pulling e991e8c on 6b7562617765726c6f73:fix_CheckCommandTest
into 630a594 on PHP-CS-Fixer:master.

@kubawerlos kubawerlos marked this pull request as ready for review February 15, 2025 12:43
@kubawerlos kubawerlos enabled auto-merge (squash) February 15, 2025 12:43
Copy link
Copy Markdown
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

would merge it earlier if there would be description in PR. it took a while to get mental readiness to understand the issue this PR is fixing with no description in the PR.

nevertheless, nice job!

@keradus keradus disabled auto-merge February 22, 2025 23:05
@keradus keradus merged commit 2dbd4a8 into PHP-CS-Fixer:master Feb 22, 2025
@keradus keradus deleted the fix_CheckCommandTest branch February 22, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants