feat: PhpCsFixer ruleset: use operator_linebreak rule for all operators#8417
Merged
kubawerlos merged 4 commits intoPHP-CS-Fixer:masterfrom Feb 20, 2025
Merged
Conversation
PhpCsFixer ruleset: use operator_linebreak rule for all operator
PhpCsFixer ruleset: use operator_linebreak rule for all operatorPhpCsFixer ruleset: use operator_linebreak rule for all operator
PhpCsFixer ruleset: use operator_linebreak rule for all operatorPhpCsFixer ruleset: use operator_linebreak rule for all operator
09926ee to
4e43910
Compare
4e43910 to
36ca9e5
Compare
PhpCsFixer ruleset: use operator_linebreak rule for all operatorPhpCsFixer ruleset: use operator_linebreak rule for all operators
kubawerlos
approved these changes
Feb 20, 2025
Member
|
Thank you @mvorisek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.and?(part of ternary operator) operators should definitely be placed consistently and on the begginning (as almost solely CS used already).=placed on a new line is little -0 from me, but if there is a strong will to place it at the end, theoperator_linebreakrule can be improved later. But IMO on CS, there should be no NL after=at all. So I fixed these changes in the last commit.