DX: Use relative fixture path as integration test case's name#7147
Merged
Wirone merged 2 commits intoPHP-CS-Fixer:masterfrom Jul 13, 2023
Merged
Conversation
f2bd6b5 to
d5bede0
Compare
Contributor
|
I made the full path so it is easier to copy-paste it to find the file, so I'm not in favor of this change. |
Member
Author
|
I don't really see any use case where full path would be helpful and actually needed. Short path like here is sufficient, longest form that should be printed is relative path from the root of the project IMHO 🙂. |
Contributor
sounds like a good compromise 👍 |
Member
Author
|
Changed the path to be relative to project's root dir. 
|
SpacePossum
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: