DX: use FAST_LINT_TEST_CASES=1 for CI run on macOS#7092
Merged
kubawerlos merged 1 commit intoPHP-CS-Fixer:masterfrom Jun 25, 2023
6b7562617765726c6f73:use_FAST_LINT_TEST_CASES_for_macOS
Merged
DX: use FAST_LINT_TEST_CASES=1 for CI run on macOS#7092kubawerlos merged 1 commit intoPHP-CS-Fixer:masterfrom 6b7562617765726c6f73:use_FAST_LINT_TEST_CASES_for_macOS
kubawerlos merged 1 commit intoPHP-CS-Fixer:masterfrom
6b7562617765726c6f73:use_FAST_LINT_TEST_CASES_for_macOS
Conversation
keradus
approved these changes
Jun 25, 2023
| - operating-system: 'macos-latest' | ||
| php-version: '8.2' | ||
| job-description: 'on macOS' | ||
| FAST_LINT_TEST_CASES: 1 |
Member
There was a problem hiding this comment.
overall +1, but pls add comment to both windows and macos build why we set up FAST_LINT_TEST_CASES for them
Contributor
|
It did not fully fix MacOS CI: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/5394285393/jobs/9795239609#step:11:402 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of writing this, there is a failed action on master, once again related to macOS run: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/5370809936/jobs/9743153345
Sometimes it is another error, writing "30 seconds timeout exceeded".
Windows job is already using it and there is a Linux job on PHP 8.2, so this change won't make PHP 8.2 not being tested with
FAST_LINT_TEST_CASESdisabled.