Skip to content

bug: PhpdocAddMissingParamAnnotationFixer - fix for promoted properties#7090

Merged
kubawerlos merged 4 commits intoPHP-CS-Fixer:masterfrom
6b7562617765726c6f73:fix_PhpdocAddMissingParamAnnotationFixer
Jun 25, 2023
Merged

bug: PhpdocAddMissingParamAnnotationFixer - fix for promoted properties#7090
kubawerlos merged 4 commits intoPHP-CS-Fixer:masterfrom
6b7562617765726c6f73:fix_PhpdocAddMissingParamAnnotationFixer

Conversation

@kubawerlos
Copy link
Copy Markdown
Member

Fixes #7075

T_PROTECTED,
T_PUBLIC,
T_STATIC,
T_VAR,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is for tokens before the function (see line 136), so T_VAR here is both incorrect and misleading.

@kubawerlos kubawerlos marked this pull request as ready for review June 25, 2023 07:50
Comment thread src/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixer.php Outdated
Co-authored-by: Greg Korba <wirone@gmail.com>
@kubawerlos kubawerlos merged commit 84c7f80 into PHP-CS-Fixer:master Jun 25, 2023
@kubawerlos kubawerlos deleted the fix_PhpdocAddMissingParamAnnotationFixer branch June 25, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect typing definition in phpdoc_add_missing_param_annotation rule

3 participants