DX: update Symfony rule set#6958
DX: update Symfony rule set#6958Wirone merged 2 commits intoPHP-CS-Fixer:masterfrom werlos:update_symfony_rule_set
Conversation
Wirone
left a comment
There was a problem hiding this comment.
Again: shouldn't dist config be changed? 😅
Reading the comment in the dist confing probably better would be to disable |
|
Thanks @kubawerlos 🍻 |
|
In terms of change
https://www.php.net/manual/en/functions.arguments.php https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.nullable |
|
@darkin1 the part:
for me applies to pretty much everything, it was added not because it is good practice, but because it is in current Symofny's standards. |
All these (obviously except
header_comment) shouldn't need to be added separately, but be in@Symfonyand@Symfony:riskysets already.