feature: Add align_multiline_comment rule to @Symfony#6875
Merged
keradus merged 1 commit intoPHP-CS-Fixer:masterfrom Apr 3, 2023
Merged
Conversation
Member
|
Thanks for the PR! |
Pull Request Test Coverage Report for Build 4585902061
💛 - Coveralls |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Apr 3, 2023
This PR was merged into the 6.3 branch. Discussion ---------- Apply align_multiline_comment PHP-CS-Fixer rule | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset. This PR apply the rule on the Symfony code base. see PHP-CS-Fixer/PHP-CS-Fixer#6875 for the PR on PHP-CS-Fixer Commits ------- 6e984f0 Apply align_multiline_comment PHP-CS-Fixer rule
Contributor
Author
|
@keradus PR merged on Symfony side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a discussion with @stof, this rule should be part of the
@SymfonyPHP-CS-Fixer ruleset.Symfony code base is (almost, see symfony/symfony#49895) following it already