bug: VoidReturnFixer - fix for intervening attributes#6863
Merged
Wirone merged 1 commit intoPHP-CS-Fixer:masterfrom Apr 20, 2023
Merged
bug: VoidReturnFixer - fix for intervening attributes#6863Wirone merged 1 commit intoPHP-CS-Fixer:masterfrom
Wirone merged 1 commit intoPHP-CS-Fixer:masterfrom
Conversation
8ac26f5 to
0c0f90a
Compare
Pull Request Test Coverage Report for Build 4551786819
💛 - Coveralls |
kubawerlos
approved these changes
Mar 26, 2023
Wirone
requested changes
Mar 27, 2023
Member
Wirone
left a comment
There was a problem hiding this comment.
I believe it would be good if there was a integration test that would ensure that @return void is removed when no_superfluous_phpdoc_tags fixer is enabled 🤔. WDYT @kubawerlos?
mvorisek
reviewed
Mar 28, 2023
0c0f90a to
3845042
Compare
Contributor
Author
I believe that would be out-of-scope of this PR. The bug report is not of a priority issue. |
Wirone
approved these changes
Apr 20, 2023
Member
|
Thank you, @paulbalandan 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6690