DX: make all testFix* methods have first parameter $expected#9289
Merged
kubawerlos merged 2 commits intoPHP-CS-Fixer:masterfrom Dec 11, 2025
Conversation
keradus
reviewed
Dec 11, 2025
| continue; | ||
| } | ||
|
|
||
| self::assertSame('expected', $parameters[0]->getName(), "First parameter name in {$reflectionObject->getName()}::{$method->getName()} is incorrectly named."); |
Member
There was a problem hiding this comment.
shouldn't we check for input and configuration too ?
Member
Author
There was a problem hiding this comment.
Definitely, I will do that in a separate PR. I play with Claude Code to make the changes to learn it.
Member
There was a problem hiding this comment.
we already have damn close test for test parameters
#9291
stakovicz
pushed a commit
to stakovicz/PHP-CS-Fixer
that referenced
this pull request
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.