feat: exception for rules via @php-cs-fixer-ignore annotation#9280
Merged
feat: exception for rules via @php-cs-fixer-ignore annotation#9280
@php-cs-fixer-ignore annotation#9280Conversation
Member
Author
8c832ef to
0725be9
Compare
0725be9 to
d0d943e
Compare
# Conflicts: # doc/rules_exceptions.rst
Contributor
|
Yep, this will be very useful! Can you try to add this test case to <?php
// @php-cs-fixer-ignore no_binary_string Ignore because of reasonsThat way we are sure that the same comment isn't detected as duplicated when the file doesn't have code. |
Member
Author
|
makes sense, added |
Member
Author
|
@mlocati i reused the validation/ensuring rules with declared exceptios are indeed supposed to be used. mind to do a review and give a green flag, if good ? |
…'s not-empty, so phpstan exception no longer needed
keradus
commented
Dec 10, 2025
# Conflicts: # src/Runner/Runner.php
Wirone
reviewed
Dec 11, 2025
Member
Wirone
left a comment
There was a problem hiding this comment.
Quick feedback without deep diving, important to address before merge/release.
stakovicz
pushed a commit
to stakovicz/PHP-CS-Fixer
that referenced
this pull request
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
complements #9107