refactor: memoize fixer names#9219
Merged
keradus merged 4 commits intoPHP-CS-Fixer:masterfrom Nov 30, 2025
Merged
Conversation
keradus
reviewed
Nov 25, 2025
Member
keradus
left a comment
There was a problem hiding this comment.
open for it, yet wondering if there is any actual impact on performance.
then, if moving this direction, why not in constructor and mark the "cached" property @readonly ?
Contributor
Author
|
I haven't measured the performance, but I guess that repeating all the calls done by getName() for every fixer and every file (in the case of RuleCustomizationPolicyInterface for example) won't be impact less. |
Contributor
Author
Done in 700356c |
keradus
reviewed
Nov 30, 2025
keradus
approved these changes
Nov 30, 2025
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
Member
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getName() method of fixers may be called more than once (for example, in a custom implementation of mine related to #9107).
That about caching its result?