feat: Add StringableForToStringFixer#9218
Merged
keradus merged 3 commits intoPHP-CS-Fixer:masterfrom Nov 28, 2025
Merged
Conversation
61b610a to
f82cd0b
Compare
Contributor
Author
|
If the Symfony core team agrees, I think we can add this new rule to the |
Co-authored-by: Kuba Werłos <werlos@gmail.com>
f82cd0b to
e4362dc
Compare
Member
check with them directly |
keradus
reviewed
Nov 26, 2025
|
|
||
| public function isCandidate(Tokens $tokens): bool | ||
| { | ||
| return \PHP_VERSION_ID >= 80_000 && $tokens->isAllTokenKindsFound([\T_CLASS, \T_STRING]); |
Member
There was a problem hiding this comment.
you applied the Fixer's changes blindly.
Suggested change
| return \PHP_VERSION_ID >= 80_000 && $tokens->isAllTokenKindsFound([\T_CLASS, \T_STRING]); | |
| return \PHP_VERSION_ID >= 8_00_00 && $tokens->isAllTokenKindsFound([\T_CLASS, \T_STRING]); |
keradus
reviewed
Nov 26, 2025
Member
keradus
left a comment
There was a problem hiding this comment.
kudos for keeping the authorship in class annotation and git-commit
@kubawerlos , want to make the review? you know the initial state of the fixer
kubawerlos
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #9186
I would like to mention that the majority of this code is part of an existing library php-cs-fixer-custom-fixers.
I also want to thank @kubawerlos as the original author of most of the code.