Skip to content

fix: FullyQualifiedStrictTypesFixer - fix crash on T_OPEN_TAG_WITH_ECHO#9217

Merged
keradus merged 4 commits intomasterfrom
testcase
Nov 25, 2025
Merged

fix: FullyQualifiedStrictTypesFixer - fix crash on T_OPEN_TAG_WITH_ECHO#9217
keradus merged 4 commits intomasterfrom
testcase

Conversation

@keradus
Copy link
Copy Markdown
Member

@keradus keradus commented Nov 24, 2025

closes #9216

@keradus keradus marked this pull request as ready for review November 24, 2025 22:14
@keradus keradus mentioned this pull request Nov 24, 2025
2 tasks
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 93.764% (-0.006%) from 93.77%
when pulling 62c4ec2 on testcase
into bb2d41f on master.

Copy link
Copy Markdown

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this fast. It should indeed not crash.

And I also fully understand why you do not want to support it.

@keradus keradus merged commit e9f096e into master Nov 25, 2025
31 of 32 checks passed
@keradus keradus deleted the testcase branch November 25, 2025 17:51
@melroy89
Copy link
Copy Markdown

melroy89 commented Nov 26, 2025

Ready for the "unfolding bike" this time 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PhpCsFixer\Linter\LintingException

3 participants