Skip to content

UX: better gitlab reporting for location.lines#9149

Merged
keradus merged 5 commits intoPHP-CS-Fixer:masterfrom
keradus:diff_gitlab
Oct 17, 2025
Merged

UX: better gitlab reporting for location.lines#9149
keradus merged 5 commits intoPHP-CS-Fixer:masterfrom
keradus:diff_gitlab

Conversation

@keradus
Copy link
Copy Markdown
Member

@keradus keradus commented Oct 17, 2025

on master, end was end startRange. some obvious mistake.
updating end with more accurate end of chunk (even while it;s not actual last modified line, it's still better)

also, adjust begin to point exact first modified line instead of begin of whole chunk

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 17, 2025

Coverage Status

coverage: 94.161% (+0.003%) from 94.158%
when pulling 73ae398 on keradus:diff_gitlab
into 4a71fae on PHP-CS-Fixer:master.

@keradus keradus marked this pull request as ready for review October 17, 2025 22:57
@keradus keradus merged commit 8e84abc into PHP-CS-Fixer:master Oct 17, 2025
31 of 32 checks passed
@keradus keradus deleted the diff_gitlab branch October 17, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants