chore: handle fixer options without allowed types defined#8973
Merged
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom Aug 24, 2025
Merged
chore: handle fixer options without allowed types defined#8973keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
Conversation
keradus
reviewed
Aug 24, 2025
| } else { | ||
| $allowedKind = 'Allowed values'; | ||
| $allowed = array_map(static fn ($value): string => $value instanceof AllowedValueSubset | ||
| ? 'a subset of ``'.Utils::toString($value->getAllowedValues()).'``' |
Member
There was a problem hiding this comment.
should we handle same for allowed values?
Member
Author
There was a problem hiding this comment.
null === $option->getAllowedValues() is checked in line 169 (implicitly).
And getAllowedValues method of AllowedValueSubset cannot return null.
keradus
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of our built-in fixers have defined allowed values or types for their options. But it is not required.