chore: ignore deprecations in token_get_all#8963
Merged
kubawerlos merged 6 commits intoPHP-CS-Fixer:masterfrom Aug 23, 2025
Merged
chore: ignore deprecations in token_get_all#8963kubawerlos merged 6 commits intoPHP-CS-Fixer:masterfrom
token_get_all#8963kubawerlos merged 6 commits intoPHP-CS-Fixer:masterfrom
Conversation
token_get_all
gharlan
commented
Aug 22, 2025
| $this->updateSizeToZero(); // clear memory | ||
| $tokens = token_get_all($code, \TOKEN_PARSE); | ||
|
|
||
| $prevErrorHandler = set_error_handler(static function ($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler) { |
Member
Author
There was a problem hiding this comment.
inspired by symfony, where this approach is used in several places. E.g., here: https://github.com/symfony/symfony/blob/32b347f826895b469b7759527d4b2f8663090797/src/Symfony/Component/Config/ResourceCheckerConfigCache.php#L154-L160
kubawerlos
approved these changes
Aug 22, 2025
keradus
reviewed
Aug 23, 2025
| $this->updateSizeToZero(); // clear memory | ||
| $tokens = token_get_all($code, \TOKEN_PARSE); | ||
|
|
||
| $prevErrorHandler = set_error_handler(static function ($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler) { |
Member
There was a problem hiding this comment.
i would wonder if we can have test dedicated to this (not only those already existing tests running on < new php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.