Skip to content

chore: PHPUnit - enforce no memory_limit#8940

Merged
keradus merged 1 commit intomasterfrom
chore_phpunit
Aug 15, 2025
Merged

chore: PHPUnit - enforce no memory_limit#8940
keradus merged 1 commit intomasterfrom
chore_phpunit

Conversation

@keradus
Copy link
Copy Markdown
Member

@keradus keradus commented Aug 15, 2025

based on recommendations in sebastianbergmann/phpunit#6297

@keradus keradus marked this pull request as ready for review August 15, 2025 14:22
Comment thread phpunit.xml.dist
<php>
<ini name="zend.enable_gc" value="0"/>
<ini name="memory_limit" value="10G"/>
<ini name="memory_limit" value="-1"/>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do it with half-measures if we can have it directly in PHP config?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to do it for CI (like your other PR).
i still need to have it in per-project config, without changing global settings of PHP on my local machine.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker or phpunit.xml?

Copy link
Copy Markdown
Member Author

@keradus keradus Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i decided to merge this PR as is.
I understand you would prefer to do it differently. it's too minor topic to waste effort on this.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 94.75% (+0.01%) from 94.74%
when pulling aecdcaf on chore_phpunit
into cacd73e on master.

@keradus keradus merged commit 440600a into master Aug 15, 2025
56 of 59 checks passed
@keradus keradus deleted the chore_phpunit branch August 15, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants