fix: TypeDeclarationSpacesFixer - handle asymmetric visibility and final properties#8900
Merged
kubawerlos merged 5 commits intoPHP-CS-Fixer:masterfrom Jul 29, 2025
Conversation
gharlan
reviewed
Jul 29, 2025
gharlan
reviewed
Jul 29, 2025
TypeDeclarationSpacesFixer - handle asymmetric visibilityTypeDeclarationSpacesFixer - handle asymmetric visibility and final properties
gharlan
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8899
This one is on me:
T_READONLYusages and tried to addT_*_SETones next to it.TypeDeclarationSpacesFixer, but I have removed the usage, and tests were still passing (see 1st commit). There were tests forreadonly, so I've assumed it is covered, but not needed in the fixer.T_READONLYwas needed, same as asymmetric visibility tokens.