What about instead of this file, which is 1.7MB, we add a test case like below?

        yield 'string with a lot of variables in braces' => [
            '<?php
                if (true) {
                    $foo = "'            . str_repeat(' text {$variable} text ', 50_000) . '";
                }',
        ];

Especially that the name of the test case is a spoiler for what is coming next: the current fix works for 👆🏼 , but not for 👇🏼 .

        yield 'string with a lot of variables' => [
            '<?php
                if (true) {
                    $foo = "'            . str_repeat(' text $variable text ', 50_000) . '";
                }',
        ];

Which would need another over 1MB if we go in the direction of explicit files.

tbh, i'm ok with both.

i think to move back to integration test.
CI is failing when code-coverage or mutation, and integration test is outside of them by default

I guess the same problem exists for concatenation of many variables..

        yield 'string with concatenation of a lot of variables' => [
            '<?php
                if (true) {
                    $foo = "'            . str_repeat(' text ".$variable." text ', 50_000) . '";
                }',
        ];

i think to move back to integration test. CI is failing when code-coverage or mutation, and integration test is outside of them by default

done

I was thinking about something like this:

• first - quick "deal breaker" for having a property hook after the variable
• second - proper check if the property hook is there

The $x could be either $index (for simplicity) or $nextToken - 1 (for microoptimization).

not sure if I grasp your idea here, want to sent a PR with it ?

If the variable is not followed by = or T_PROPERTY_HOOK_BRACE_OPEN, it cannot be a property with hooks.
In the given test cases it would be a fast fail for all variables inside the string.
Only for the first $foo = ... variable it would still traverse through all tokens in the long statement to the statement end (;).