chore(release): bump php ci alpine version#8581
Merged
keradus merged 1 commit intoPHP-CS-Fixer:masterfrom Apr 18, 2025
Merged
Conversation
keradus
reviewed
Apr 14, 2025
| alpine-version: '3.21' | ||
| - php-version: '8.3' | ||
| alpine-version: '3.18' | ||
| alpine-version: '3.21' |
Member
There was a problem hiding this comment.
any idea how to avoid declaring the list in 2 places?
as we have 2 places, they diverge over time ;(
https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/compose.yaml#L28
Contributor
Author
There was a problem hiding this comment.
Yes it could be avoidable, but will involve quite big changes or refactoring on Dockerfile, compose files and some workflows. I could work on a new feature branch as a PoC.
keradus
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump PHP-CS-Fixer docker alpine version