chore: add return types for remaining data providers#8544
Merged
kubawerlos merged 2 commits intoPHP-CS-Fixer:masterfrom Mar 30, 2025
Merged
chore: add return types for remaining data providers#8544kubawerlos merged 2 commits intoPHP-CS-Fixer:masterfrom
kubawerlos merged 2 commits intoPHP-CS-Fixer:masterfrom
Conversation
keradus
reviewed
Mar 30, 2025
| } | ||
|
|
||
| /** | ||
| * @return iterable<array{0: string, 1?: string}> |
Member
There was a problem hiding this comment.
can we use following ?
Suggested change
| * @return iterable<array{0: string, 1?: string}> | |
| * @return iterable<string, array{0: string, 1?: string}> |
Member
Author
There was a problem hiding this comment.
No:
------ -----------------------------------------------------------------
Line tests/Fixer/ControlStructure/SwitchContinueToBreakFixerTest.php
------ -----------------------------------------------------------------
269 Generator expects key type string, int given.
🪪 generator.keyType
432 Generator expects key type string, int given.
🪪 generator.keyType
------ -----------------------------------------------------------------
Member
There was a problem hiding this comment.
aaaaand, especially one of them is from code you touch in this PR
I see no reason why not to fix that single case that was missing the description.
keradus
reviewed
Mar 30, 2025
Comment on lines
-427
to
+433
| [ | ||
| '<?php | ||
| ]; | ||
|
|
||
| yield [ | ||
| '<?php |
Member
There was a problem hiding this comment.
looks like there was some mistake in master branch of 2 cases merged into 1 weirdly [string, string, [string, string]],
but now the case-description here doesn't make sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.