fix: PhpUnitTestClassRequiresCoversFixer must run before PhpUnitAttributesFixer#8444
Conversation
| * | ||
| * Must run before FullyQualifiedStrictTypesFixer, NoEmptyPhpdocFixer, PhpdocSeparationFixer, PhpdocTrimConsecutiveBlankLineSeparationFixer, PhpdocTrimFixer. | ||
| * Must run after PhpUnitDataProviderNameFixer, PhpUnitDataProviderReturnTypeFixer, PhpUnitDataProviderStaticFixer. | ||
| * Must run after PhpUnitDataProviderNameFixer, PhpUnitDataProviderReturnTypeFixer, PhpUnitDataProviderStaticFixer, PhpUnitTestClassRequiresCoversFixer. |
There was a problem hiding this comment.
It also must run after php_unit_size_class and php_unit_internal_class.
There was a problem hiding this comment.
It also must run after
php_unit_size_classandphp_unit_internal_class.
And also probably a few others... @Wirone please focus and review this PR, which is fixing priorities between those 2 fixers. Have you heard about Single-responsibility principle? It is not forbidden to apply it to pull requests, you know.
There was a problem hiding this comment.
it is a good note. on PR level, it's hard to say in advance if this was not done due to lack of awareness that it should be done as well, or because it was explicitly not plan as out of scope - no need to be harsh.
same time, totally OK to make it out of scope and solve separately.
There was a problem hiding this comment.
moved to #8455 . if one of you can pick it up later, fantastic.
No description provided.