feat: Fix whitespace between const type and const name.#8442
Merged
kubawerlos merged 4 commits intoPHP-CS-Fixer:masterfrom Feb 20, 2025
Merged
Conversation
keradus
reviewed
Feb 17, 2025
| ->setAllowedValues([new AllowedValueSubset(['function', 'property'])]) | ||
| ->setDefault(['function', 'property']) | ||
| ->setAllowedValues([new AllowedValueSubset(['function', 'property', 'constant'])]) | ||
| ->setDefault(['function', 'property', 'constant']) |
Member
There was a problem hiding this comment.
Suggested change
| ->setDefault(['function', 'property', 'constant']) | |
| ->setDefault(['function', 'property']) // @TODO add 'constant' on next major 4.0 |
to keep BC
keradus
reviewed
Feb 17, 2025
Member
keradus
left a comment
There was a problem hiding this comment.
overall, looking nice so far, thanks for picking this up!
Found one change needed to be updated.
PR is draft, anything else you have in plans here?
Contributor
Author
|
Thank you for your feedback. The PR is ready for review—I just wanted to double-check it. |
kubawerlos
approved these changes
Feb 20, 2025
Member
|
Thank you @obresoft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #7446