fix: SingleSpaceAroundConstructFixer - handle alternative syntax#8317
Merged
kubawerlos merged 8 commits intoPHP-CS-Fixer:masterfrom Mar 6, 2025
Merged
fix: SingleSpaceAroundConstructFixer - handle alternative syntax#8317kubawerlos merged 8 commits intoPHP-CS-Fixer:masterfrom
SingleSpaceAroundConstructFixer - handle alternative syntax#8317kubawerlos merged 8 commits intoPHP-CS-Fixer:masterfrom
Conversation
keradus
reviewed
Dec 10, 2024
Member
keradus
left a comment
There was a problem hiding this comment.
-0
i'm explicitly encouraging to not use alternative syntax, only case I see for it is in templates, but I also encourage to use any templates engine rather than directly PHP for it.
with that, I'm not gonna spend any time to support alternative syntax myself, but OKish to merge validated changes provided by userland.
SingleSpaceAroundConstructFixer - handle alternative syntax
kubawerlos
requested changes
Feb 21, 2025
tests/Fixer/LanguageConstruct/SingleSpaceAroundConstructFixerTest.php
Outdated
Show resolved
Hide resolved
kubawerlos
reviewed
Mar 6, 2025
kubawerlos
reviewed
Mar 6, 2025
tests/Fixer/LanguageConstruct/SingleSpaceAroundConstructFixerTest.php
Outdated
Show resolved
Hide resolved
kubawerlos
approved these changes
Mar 6, 2025
Member
|
Thank you @timsmid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8316.