Skip to content

bug: PhpUnitMockShortWillReturnFixer - fix for trailing commas#6900

Merged
Wirone merged 3 commits intoPHP-CS-Fixer:masterfrom
werlos:fix_PhpUnitMockShortWillReturnFixer
Apr 20, 2023
Merged

bug: PhpUnitMockShortWillReturnFixer - fix for trailing commas#6900
Wirone merged 3 commits intoPHP-CS-Fixer:masterfrom
werlos:fix_PhpUnitMockShortWillReturnFixer

Conversation

@kubawerlos
Copy link
Copy Markdown
Member

Fixes #6896

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4746984920

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0009%) to 93.005%

Totals Coverage Status
Change from base Build 4600797305: 0.0009%
Covered Lines: 22737
Relevant Lines: 24447

💛 - Coveralls

@kubawerlos kubawerlos marked this pull request as ready for review April 19, 2023 20:31
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4747394383

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0009%) to 93.005%

Totals Coverage Status
Change from base Build 4600797305: 0.0009%
Covered Lines: 22737
Relevant Lines: 24447

💛 - Coveralls

Copy link
Copy Markdown
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add test case with willReturnCallback() like on bug report? Maybe it does not matter that much, but would be good to see it passing.

@kubawerlos
Copy link
Copy Markdown
Member Author

@Wirone we can't because that one is fine for PhpUnitMockShortWillReturnFixer, the problem happens with trailing_comma_in_multiline adds trailing commas earlier.

@Wirone
Copy link
Copy Markdown
Member

Wirone commented Apr 19, 2023

@kubawerlos so maybe integration test that would simulate this?

@Wirone Wirone merged commit 8f88660 into PHP-CS-Fixer:master Apr 20, 2023
@Wirone
Copy link
Copy Markdown
Member

Wirone commented Apr 20, 2023

Thank you, @kubawerlos 🍻

@vudaltsov
Copy link
Copy Markdown
Contributor

Thank you!

@kubawerlos kubawerlos deleted the fix_PhpUnitMockShortWillReturnFixer branch April 20, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse error when refactoring to willReturnCallback

4 participants