bug: PhpUnitMockShortWillReturnFixer - fix for trailing commas#6900
Merged
Wirone merged 3 commits intoPHP-CS-Fixer:masterfrom Apr 20, 2023
werlos:fix_PhpUnitMockShortWillReturnFixer
Merged
bug: PhpUnitMockShortWillReturnFixer - fix for trailing commas#6900Wirone merged 3 commits intoPHP-CS-Fixer:masterfrom werlos:fix_PhpUnitMockShortWillReturnFixer
Wirone merged 3 commits intoPHP-CS-Fixer:masterfrom
werlos:fix_PhpUnitMockShortWillReturnFixer
Conversation
Pull Request Test Coverage Report for Build 4746984920
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4747394383
💛 - Coveralls |
Wirone
requested changes
Apr 19, 2023
Member
Wirone
left a comment
There was a problem hiding this comment.
Can we add test case with willReturnCallback() like on bug report? Maybe it does not matter that much, but would be good to see it passing.
Member
Author
|
@Wirone we can't because that one is fine for |
Member
|
@kubawerlos so maybe integration test that would simulate this? |
Wirone
approved these changes
Apr 19, 2023
Member
|
Thank you, @kubawerlos 🍻 |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6896