Skip to content

minor: PHP8.2 Docker runtime#6833

Merged
kubawerlos merged 5 commits intoPHP-CS-Fixer:masterfrom
Wirone:codito/php8.2-docker-runtime
Mar 26, 2023
Merged

minor: PHP8.2 Docker runtime#6833
kubawerlos merged 5 commits intoPHP-CS-Fixer:masterfrom
Wirone:codito/php8.2-docker-runtime

Conversation

@Wirone
Copy link
Copy Markdown
Member

@Wirone Wirone commented Mar 13, 2023

Missing in v3.15 release, we should provide environment for 8.2 out-of-the-box.

@Wirone
Copy link
Copy Markdown
Member Author

Wirone commented Mar 13, 2023

After configuring server in IDE it works, for example docker-compose run php-8.2 xdebug vendor/bin/phpunit tests/Fixer/Casing/NativeFunctionTypeDeclarationCasingFixerTest.php:

image

I get segmentation fault when adding breakpoint at NativeFunctionTypeDeclarationCasingFixer at line 121 (inside isCandidate()), though. I am not sure if it's problem with the runtime config, XDebug 3.2.0 (which is required by PHP 8.2) or @julienfalque's xdebug script.

@Wirone Wirone requested a review from julienfalque March 13, 2023 16:22
@Wirone Wirone mentioned this pull request Mar 13, 2023
Merged
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4515117684

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.994%
Totals Coverage Status
Change from base Build 4490159172: 0.0%
Covered Lines: 22671
Relevant Lines: 24379
💛 - Coveralls

@keradus keradus changed the title feature: PHP8.2 Docker runtime minor: PHP8.2 Docker runtime Mar 13, 2023
@Wirone Wirone mentioned this pull request Mar 14, 2023
Merged
patgrudniewski
patgrudniewski reviewed Mar 15, 2023
View reviewed changes
Comment thread docker/php-8.2/xdebug.ini Outdated
Comment thread docker/php-8.2/xdebug.ini
Comment thread docker/php-8.2/xdebug.ini
@patgrudniewski patgrudniewski mentioned this pull request Mar 15, 2023
Merged
@Wirone Wirone force-pushed the codito/php8.2-docker-runtime branch from 33689dd to 82780ef Compare March 16, 2023 12:22
@Wirone Wirone force-pushed the codito/php8.2-docker-runtime branch from 82780ef to f784409 Compare March 22, 2023 22:59
kubawerlos
kubawerlos reviewed Mar 23, 2023
View reviewed changes
Comment thread .gitignore Outdated
@kubawerlos kubawerlos merged commit 7ac5fae into PHP-CS-Fixer:master Mar 26, 2023
@kubawerlos
Copy link
Copy Markdown
Member

kubawerlos commented Mar 26, 2023

thank you @Wirone

@Wirone Wirone deleted the codito/php8.2-docker-runtime branch March 26, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kubawerlos kubawerlos kubawerlos approved these changes

@julienfalque julienfalque Awaiting requested review from julienfalque

+1 more reviewer

@patgrudniewski patgrudniewski patgrudniewski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Wirone @coveralls @kubawerlos @patgrudniewski